Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data model aliases inside select #510

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Fix data model aliases inside select #510

merged 4 commits into from
Sep 17, 2023

Conversation

Dakror
Copy link
Contributor

@Dakror Dakror commented Sep 8, 2023

Fixes #509

@Dakror Dakror marked this pull request as draft September 8, 2023 15:47
@Dakror Dakror marked this pull request as ready for review September 10, 2023 10:56
mikke89
mikke89 reviewed Sep 10, 2023
View reviewed changes
Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, code looks good to me. Only thing I would like is either a test, or changes to the databinding sample so that we can see if this stops working.

@Dakror
Copy link
Contributor Author

Dakror commented Sep 10, 2023

Will do

@Dakror Dakror requested a review from mikke89 September 13, 2023 15:59
mikke89
mikke89 approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test, thank you!

@mikke89 mikke89 merged commit a9bb4ac into mikke89:master Sep 17, 2023
13 checks passed
@Dakror Dakror deleted the fix-data-for-in-select branch September 18, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikke89 mikke89 mikke89 approved these changes

Assignees
No one assigned
Labels
data binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data-For not working for option inside select
2 participants
@Dakror @mikke89