Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS - set compatability flag for GL3 #522

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

NaLiJa
Copy link
Contributor

@NaLiJa NaLiJa commented Oct 17, 2023

Fix GLFW error (0x10007): NSGL: The targeted version of macOS only supports forward-compatible core profile contexts for OpenGL 3.2 and above

…pports forward-compatible core profile contexts for OpenGL 3.2 and above
@mikke89 mikke89 added the backends Platforms and renderers label Oct 17, 2023
@mikke89
Copy link
Owner

mikke89 commented Oct 17, 2023

Thanks for the pull request! I looked into the deprecated features, and we're definitely not relying on any of those. So this should be good in my view.

I wonder if we can set this hint regardless of platform? If we can, I would prefer this. Do you know if there are any situations where forward compatible context could fail, where it would otherwise succeed? I briefly tested it locally (windows/nvidia), and it works well for me.

If you cannot find any counter-examples, then I'd appreciate removing the if condition, and we can instead add it back if other users report any issues.

@NaLiJa
Copy link
Contributor Author

NaLiJa commented Oct 18, 2023

Yes, it should be save to remove the Apple tag if RmlUi is not using any of the deprecated featries! Have changed the PR accordingly!

@mikke89 mikke89 merged commit 1d9b651 into mikke89:master Oct 18, 2023
13 of 14 checks passed
@mikke89
Copy link
Owner

mikke89 commented Oct 18, 2023

Perfect, thank you for contributing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backends Platforms and renderers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants