Some small fixes for cmake macos build #525
Conversation
…pports forward-compatible core profile contexts for OpenGL 3.2 and above
There was a problem hiding this comment.
Hey, thanks for another nice pull request!
I don't have any experience with bundles, and I'm not really able to test this. As longs as this mainly affects apple platforms, I'm fine with delegating and trusting users to update and maintain this. So I guess you can consider yourself the maintainer of this part from here-on out ;)
Please be aware of the (massive) CMake changes in #446. Maybe you could sync up with that at some point, and in particular read the CMake contributing guide. But I'm perfectly fine with integrating these smaller fixups here first.
By the way, I see that you're including some unrelated/older commits in this PR. It would be helpful if you could rebase with only the new (PR-related) commits on top of master.
|
Hi there, fixed the above! Yes, the SDIR was referring to the subdir as I need to copy the folder structure to the app bundle. Have renamed it! Will also have a look at the refactored cmake and try to adapt! I have with little steps started with looking into adding glfm as a backend, but I cannot say yet if this leads to anything useable. |
|
Thanks for the quick update!
Sounds interesting, let us know how it goes. |
When building rlottie according to rlottie docs, the libs are in the build subdirectory, so cmake cannot find the inc folder. Adjusted search path.
The sample apps were broken on macos because the assets and data files were not added to the app bundle. Added file copying to bl_samlpes macro. Not sure if this is the preferred cmake way to get the files into the bundle without the need to list each file separately as resource.
At the moment the app bundles are not self contained yet when using libs from the system, e.g. via homebrew like freetype, glfw,... will create a separate PR for this later.