Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVGPlugin, adapt to lunasvg change of default bitmap format #528

Closed
wants to merge 1 commit into from

Conversation

NaLiJa
Copy link
Contributor

@NaLiJa NaLiJa commented Oct 23, 2023

In the demo the colors of the svg are wrong, because lunasvg has changed the default bitmap format to argb:
sammycage/lunasvg#73

in the appveyor.yml it pulls version 2.3.1 of lunasvg, so this must be updated

@mikke89 mikke89 added the plugin SVG and Lottie plugins label Oct 23, 2023
@mikke89
Copy link
Owner

mikke89 commented Oct 23, 2023

Thanks for another pull request!

This one in particular is already fixed in the 'effects' branch: 70bcdc7

The effects branch also makes it correctly rendered in terms of pre-multiplied alpha. I think it's better to wait for that branch to be merged, rather than dealing with the conflicts later. So we just needs a bit more patience in this case :) Cheers, keep the contributions coming though, they are very much appreciated.

@mikke89 mikke89 closed this Oct 23, 2023
@NaLiJa NaLiJa deleted the svgplugin branch October 24, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin SVG and Lottie plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants