Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ElementTabSet::RemoveTab to work on tabsets with no panels. #546

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

exjam
Copy link
Contributor

@exjam exjam commented Dec 3, 2023

All the other methods in ElementTabSet seem to operate on tabs and panels independently, so why not this one too!

I bumped into this issue whilst using a tabset with no panels where I am using tabset in the same way that someone may use radio buttons.

@mikke89 mikke89 added the enhancement New feature or request label Dec 6, 2023
@mikke89
Copy link
Owner

mikke89 commented Dec 6, 2023

Thanks for the PR, nice to see first-time contributors!

This looks good to me. I'm curious to know more about how you use the tabset like this, if you'd like to share.

@mikke89 mikke89 merged commit bb25b88 into mikke89:master Dec 6, 2023
18 checks passed
@exjam
Copy link
Contributor Author

exjam commented Dec 6, 2023

After making this PR I actually ended up moving to a data-for with buttons because I learnt that data-for doesn't work on tabset, and the use of data-for is what led me to my other PR for dynamic array indexing. We are very slowly replacing the custom UI system in an MMORPG, and what I have been working on recently is the chatbox - so I had tabs (now buttons) which were used to change the filtering on the chat message view. Instead of properly using tabs with a panel per chat tab, I just used the tab buttons to control the filtering of message types in the single message container.

@mikke89
Copy link
Owner

mikke89 commented Dec 6, 2023

Very cool, glad to have you on-board! I'm always interested to hear more about projects and how they develop. Feel free to share some screenshots for the gallery too when you feel ready for that.

alml pushed a commit to alml/RmlUi that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants