Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-schema generation for nested config entries with _target_ #48

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Sep 6, 2024

The auto-schema generation for nested config entries with a _target_ was not working correctly. This pull request fixes the issue by properly handling nested entries and generating the schema based on the target signature. Additionally, a description is added to the generated schema to indicate that it is based on the signature of the target.

Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (32ae062) to head (e85bf3e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   70.72%   70.40%   -0.32%     
==========================================
  Files          57       58       +1     
  Lines        3593     3589       -4     
==========================================
- Hits         2541     2527      -14     
- Misses       1052     1062      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice marked this pull request as ready for review September 9, 2024 21:02
@lebrice lebrice merged commit e6925d9 into master Sep 9, 2024
10 checks passed
@lebrice lebrice deleted the auto-schema-tweaks branch September 9, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants