Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the network config group and make it optional #51

Merged
merged 14 commits into from
Sep 30, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Sep 11, 2024

Fixes #49

Signed-off-by: Fabrice Normandin [email protected]

@lebrice lebrice changed the title Lebrice/make-network-optional Move the network config group and make it optional Sep 11, 2024
@lebrice lebrice force-pushed the lebrice/make-network-optional branch from a11df99 to 3f99694 Compare September 26, 2024 14:27
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 86.14458% with 23 lines in your changes missing coverage. Please review.

Project coverage is 70.49%. Comparing base (725d9fa) to head (f688c6b).

Files with missing lines Patch % Lines
project/conftest.py 74.28% 9 Missing ⚠️
project/utils/utils.py 55.55% 4 Missing ⚠️
project/algorithms/hf_example_test.py 66.66% 3 Missing ⚠️
project/experiment.py 81.81% 2 Missing ⚠️
project/main.py 0.00% 2 Missing ⚠️
project/algorithms/example.py 93.33% 1 Missing ⚠️
project/algorithms/testsuites/algorithm_tests.py 96.00% 1 Missing ⚠️
project/datamodules/datamodules_test.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   70.31%   70.49%   +0.17%     
==========================================
  Files          58       58              
  Lines        3571     3552      -19     
==========================================
- Hits         2511     2504       -7     
+ Misses       1060     1048      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice marked this pull request as ready for review September 30, 2024 17:22
@lebrice lebrice merged commit 3296b9f into master Sep 30, 2024
7 checks passed
@lebrice lebrice deleted the lebrice/make-network-optional branch September 30, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: Rework the network config group to be optional, under algorithm
2 participants