Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create schemas for yaml config used by Hydra #7

Merged
merged 28 commits into from
Aug 26, 2024

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Jun 20, 2024

The goal is to automatically create schemas for the config files based on the _target_.

  • This will be very helpful because it shows directly in the code editor what fields can be specified and what their default values are.

We could possibly create a standalone hydra plugin for this so it can be used by anyone that uses Hydra.

Demo:

demo_cropped.mp4

@lebrice lebrice changed the title Automatically create schema for yaml config files of Hydra Automatically create schemas for yaml config used by Hydra Jun 20, 2024
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@lebrice lebrice marked this pull request as ready for review August 21, 2024 18:31
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 85.79041% with 80 lines in your changes missing coverage. Please review.

Project coverage is 71.08%. Comparing base (0cc6956) to head (53f3400).
Report is 2 commits behind head on master.

Files Patch % Lines
project/utils/auto_schema.py 84.22% 77 Missing ⚠️
project/utils/auto_schema_test.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   66.21%   71.08%   +4.87%     
==========================================
  Files          52       54       +2     
  Lines        2921     3455     +534     
==========================================
+ Hits         1934     2456     +522     
- Misses        987      999      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@lebrice lebrice merged commit 2bb1a5d into master Aug 26, 2024
6 checks passed
@lebrice lebrice deleted the yaml_schema branch August 26, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants