-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python libraries #172
Conversation
soline-b
commented
Oct 13, 2023
- Update versions in requirements of python libraries
- Retrieve flask-login by cloning main branch of the Git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using pip freeze is not a bad idea, but there should be a source file with only our direct dependencies, to use when we update the pip freeze since otherwise it will be a major pain to update.
That's a good point! Thank you! It should be fixed in commit b58b1b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to have files on the side (like requirements_orig.txt
) with only our requirements and leave the pip freeze requirements in requirements.txt
. But this is fine too.
I'll leave you to merge it if you want to do what I said or leave it as-is.
Sorry for the misunderstanding, and thanks for your clarification |