Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python libraries #172

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Update python libraries #172

merged 6 commits into from
Oct 19, 2023

Conversation

soline-b
Copy link
Collaborator

  • Update versions in requirements of python libraries
  • Retrieve flask-login by cloning main branch of the Git

@soline-b soline-b marked this pull request as draft October 13, 2023 16:37
@soline-b soline-b marked this pull request as ready for review October 13, 2023 16:44
@soline-b soline-b requested a review from gyom October 13, 2023 18:24
@soline-b soline-b marked this pull request as draft October 17, 2023 13:20
@soline-b soline-b marked this pull request as ready for review October 17, 2023 20:04
Copy link
Collaborator

@abergeron abergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pip freeze is not a bad idea, but there should be a source file with only our direct dependencies, to use when we update the pip freeze since otherwise it will be a major pain to update.

@soline-b
Copy link
Collaborator Author

Using pip freeze is not a bad idea, but there should be a source file with only our direct dependencies, to use when we update the pip freeze since otherwise it will be a major pain to update.

That's a good point! Thank you! It should be fixed in commit b58b1b0

Copy link
Collaborator

@abergeron abergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to have files on the side (like requirements_orig.txt) with only our requirements and leave the pip freeze requirements in requirements.txt. But this is fine too.

I'll leave you to merge it if you want to do what I said or leave it as-is.

@soline-b
Copy link
Collaborator Author

Sorry for the misunderstanding, and thanks for your clarification

@soline-b soline-b merged commit 71d4d8f into master Oct 19, 2023
1 check passed
@soline-b soline-b deleted the fix-werkzeug-version-bug branch October 24, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants