-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACL example #121
Add ACL example #121
Conversation
4aaf3c3
to
f9ef26e
Compare
@obilaniu , could you quickly look if this is the format you had in mind? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's all good! Thanks for translating from Markdown!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny typo.
Also, while this is very cool, this does not cover all topics of #115. I believe we won't be able to address all topics in a single PR, so I will remove the resolves #115
to avoid case closure.
@vict0rsch: Any feedback on these ACL examples? |
Co-authored-by: Bruno Travouillon <[email protected]>
docs/Userguide_sharing_data.rst
Outdated
|
||
---- | ||
|
||
| In order to access a file, all folders from the root (``/``) down to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part of the previous section on "searching"? It looks like it's its own different example, but the content seems like it's part of the previous block
Thank you for working on this! I've made a bunch of comments. I think this is still a little raw and rough for beginners to understand completely though. In particular, I think this PR needs an explicit section on Projects and the ideal workflow for collaborators not to get confused with permissions and people not having access to others' data etc. I'm thinking about a "Good practices for Projects" section with the elements mentioned in #115:
It's fine to have it on another PR but I think this is a very important topic so maybe it can be dealt with in a single one. (On that note, can you not make it default that any and all members of a group have |
@obilaniu would you have some time available to update the PR in regards to @vict0rsch comments? |
@obilaniu would you have some time available to update the PR in regards to @vict0rsch comments? |
@saleml does not know what ACLs are. He'll be a great tester for this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
Relates to #115