Fix llama3 generation #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
satyaog
commented
Sep 10, 2024
•
satyaog
commented
- force bf16 instead of f32 to have the same model size are pretrained
- fix no_pretrained arg
Delaunay
reviewed
Sep 11, 2024
benchmarks/llm/prepare.py
Outdated
| @@ -154,7 +162,7 @@ def main(): | |||
|
|
|||
| # | |||
| huggingface_format = config.get("safetensors", False) | |||
| pretrained = not args.no_pretrained | |||
| pretrained = not config.get("no_pretrained", False) | |||
There was a problem hiding this comment.
I am not a fan of "no_xxx" configs, but nothing else comes to mind.
Do you have suggestions ?
There was a problem hiding this comment.
Is pretrained already in used somewhere? Else I'm not sure if we have access to the bench config (from config/*.yaml) there but that would be cleaner I supposed?
There was a problem hiding this comment.
Or the arg could be untrained
satyaog
force-pushed
the
hotfix/llama3_gen
branch
from
bc84701
to
8cc4926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.