Skip to content

Commit

Permalink
Fix: hook --post-settings should be after all settings has been done
Browse files Browse the repository at this point in the history
This hook was positioned *after* code which was doing some DB operations
(ie. checking Doctrine migrations). To be strict, it should be run
*before* that step.
  • Loading branch information
ryzy committed Feb 9, 2016
1 parent 5b1595f commit 47db98c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions container-files/build-typo3-app/configure-typo3-app.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ if [ "${T3APP_DO_INIT^^}" = TRUE ]; then
update_settings_yaml "Configuration/Production/Settings.yaml" $T3APP_DB_NAME
update_settings_yaml "Configuration/Development/Settings.yaml" $T3APP_DB_NAME

hook_user_build_script --post-settings

# DB migration: where are we? Also export it so site build script can access to that info.
log "DB status: checking migration status..."
executed_migrations=$(get_db_executed_migrations)
export RUNTIME_EXECUTED_MIGRATIONS=$executed_migrations
log "DB status: $executed_migrations migrations executed."

hook_user_build_script --post-settings

if [[ $(./flow help | grep "database:setcharset") ]]; then # Only run if this command is available (not in Flow < 3.0)
./flow database:setcharset
fi
Expand Down

0 comments on commit 47db98c

Please sign in to comment.