[issue 1147] Fix dimension calculation in BinaryVector by replacing position() with limit() #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Yiling1f The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @Yiling1f! It looks like this is your first PR to milvus-io/milvus-sdk-java 🎉 |
…osition() with limit() Signed-off-by: l00909895 <[email protected]>
Yiling1f
force-pushed
the
fix/issue-1147
branch
from
bf1cb4a
to
3b87d43
Compare
|
/assign @yhmo |
|
Thank you for finding this bug. There are more places called the position () and I just submitted another pr #1154 to fix it completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been modified to use ByteBuffer.limit() instead of position() in calculateBinVectorDim. The limit() method correctly reflects the length of the data in bytes, ensuring the dimension is calculated accurately and matches the field’s schema.
Issue Reference
This PR resolves the issue related to incorrect dimension checking as discussed in Issue #<Issue_Number>.