enhance: [2.4]Skip load delta data in delegater when using RemoteLoad (#37082) #37112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vus-io#37082) Related to milvus-io#35303 Delta data is not needed when using `RemoteLoad` l0 forward policy. By skipping load delta data, memory pressure could be eased if l0 segment size/number is large. Signed-off-by: Congqi Xia <[email protected]>
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37112 +/- ##
==========================================
+ Coverage 79.67% 80.61% +0.93%
==========================================
Files 1066 1066
Lines 165082 165094 +12
==========================================
+ Hits 131524 133083 +1559
+ Misses 29216 27669 -1547
Partials 4342 4342
|
yanliang567
added
ci-passed
manual-pass
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 25, 2024
Related to milvus-io#37112 Skip load logic used to work only when there is multiple segment load info entires in load request. In continous delete case, delegator still loads l0 segment, which occupies lot of memory. Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 25, 2024
Related to milvus-io#37112 Skip load logic used to work only when there is multiple segment load info entires in load request. In continous delete case, delegator still loads l0 segment, which occupies lot of memory. Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Cherry-pick from master pr: #37160 Related to #37112 Skip load logic used to work only when there is multiple segment load info entires in load request. In continous delete case, delegator still loads l0 segment, which occupies lot of memory. Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 25, 2024
Related to #37112 Skip load logic used to work only when there is multiple segment load info entires in load request. In continous delete case, delegator still loads l0 segment, which occupies lot of memory. Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #37082
Related to #35303
Delta data is not needed when using
RemoteLoadl0 forward policy. By skipping load delta data, memory pressure could be eased if l0 segment size/number is large.