Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [codecov]split code coverage into components #37137

Merged
merged 2 commits into from
Oct 25, 2024
Merged

enhance: [codecov]split code coverage into components #37137

merged 2 commits into from
Oct 25, 2024

Conversation

yellow-shine
Copy link
Collaborator

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 25, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (1d61b60) to head (31e90a0).
Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37137       +/-   ##
===========================================
+ Coverage   66.87%   80.99%   +14.12%     
===========================================
  Files         276     1303     +1027     
  Lines       24994   181750   +156756     
===========================================
+ Hits        16715   147216   +130501     
- Misses       8279    29382    +21103     
- Partials        0     5152     +5152
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.92% <ø> (+0.04%) ⬆️
Go 83.26% <ø> (∅)

see 1031 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@yellow-shine E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yellow-shine
Copy link
Collaborator Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@yellow-shine E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@yellow-shine E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia
congqixia approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yellow-shine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 139f4e5 into milvus-io:master Oct 25, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@xige-16 xige-16 Awaiting requested review from xige-16

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@congqixia congqixia

Labels
approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yellow-shine @sre-ci-robot @congqixia