Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Return deltadata for DeleteCodec.Deserialize (#37214) #37264

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #37214
Related to #35303 #30404

This PR change return type of DeleteCodec.Deserialize from storage.DeleteData to DeltaData, which
reduces the memory usage of interface header.

Also refine storage.DeltaData methods to make it easier to usage.

)

Related to milvus-io#35303 milvus-io#30404

This PR change return type of `DeleteCodec.Deserialize` from
`storage.DeleteData` to `DeltaData`, which
reduces the memory usage of interface header.

Also refine `storage.DeltaData` methods to make it easier to usage.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Oct 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 29, 2024
Copy link
Contributor

mergify bot commented Oct 29, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Oct 29, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 89.33333% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.5@7134526). Learn more about missing BASE report.
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/querynodev2/segments/segment_loader.go 37.50% 3 Missing and 2 partials ⚠️
internal/storage/data_codec.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.5   #37264   +/-   ##
======================================
  Coverage       ?   80.83%           
======================================
  Files          ?     1319           
  Lines          ?   182748           
  Branches       ?        0           
======================================
  Hits           ?   147720           
  Misses         ?    29841           
  Partials       ?     5187           
Components Coverage Δ
Client ∅ <ø> (?)
Core 66.91% <ø> (?)
Go 83.10% <89.33%> (?)
Files with missing lines Coverage Δ
internal/datanode/iterators/deltalog_iterator.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment.go 65.47% <100.00%> (ø)
internal/querynodev2/segments/segment_l0.go 71.87% <100.00%> (ø)
internal/storage/delta_data.go 100.00% <100.00%> (ø)
internal/storage/primary_keys.go 100.00% <100.00%> (ø)
internal/storage/data_codec.go 77.79% <66.66%> (ø)
internal/querynodev2/segments/segment_loader.go 72.67% <37.50%> (ø)

@mergify mergify bot added the ci-passed label Oct 29, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ee6ce8c into milvus-io:2.5 Oct 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants