-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.5] Return deltadata for DeleteCodec.Deserialize
(#37214)
#37264
Conversation
) Related to milvus-io#35303 milvus-io#30404 This PR change return type of `DeleteCodec.Deserialize` from `storage.DeleteData` to `DeltaData`, which reduces the memory usage of interface header. Also refine `storage.DeltaData` methods to make it easier to usage. Signed-off-by: Congqi Xia <[email protected]>
@congqixia cpp-unit-test check failed, comment |
rerun cpp-unit-test |
@congqixia go-sdk check failed, comment |
rerun go-sdk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #37264 +/- ##
======================================
Coverage ? 80.83%
======================================
Files ? 1319
Lines ? 182748
Branches ? 0
======================================
Hits ? 147720
Misses ? 29841
Partials ? 5187
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick from master
pr: #37214
Related to #35303 #30404
This PR change return type of
DeleteCodec.Deserialize
fromstorage.DeleteData
toDeltaData
, whichreduces the memory usage of interface header.
Also refine
storage.DeltaData
methods to make it easier to usage.