-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [cp24]Change memoryCheck write lock to read lock #37526
Conversation
@XuanYang-cn E2e jenkins job failed, comment |
e263951
to
9e9f6b2
Compare
@XuanYang-cn E2e jenkins job failed, comment |
9e9f6b2
to
ed4bf5c
Compare
See also: milvus-io#37493 pr: milvus-io#37525 Signed-off-by: yangxuan <[email protected]>
ed4bf5c
to
37ff874
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37526 +/- ##
==========================================
+ Coverage 72.25% 77.97% +5.71%
==========================================
Files 1069 1061 -8
Lines 166881 165748 -1133
==========================================
+ Hits 120588 129250 +8662
+ Misses 41878 32084 -9794
+ Partials 4415 4414 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pr: #37525