Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Enable RemoteLoad l0 forward policy by default #37678

Conversation

congqixia
Copy link
Contributor

Related to #35303

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (31a8d08) to head (523c038).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37678      +/-   ##
==========================================
- Coverage   82.49%   80.54%   -1.96%     
==========================================
  Files        1067     1357     +290     
  Lines      165006   190463   +25457     
==========================================
+ Hits       136126   153407   +17281     
- Misses      23473    31632    +8159     
- Partials     5407     5424      +17     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.08% <33.33%> (∅)
Go 83.17% <100.00%> (-0.04%) ⬇️
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.34% <100.00%> (ø)

... and 339 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 14, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 66bf254 into milvus-io:master Nov 15, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 15, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 15, 2024
…) (#37713)

Cherry-pick from master
pr: #37678
Related to #35303

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants