Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Reduce GetIndexInfos calls #37695

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

Batch GetIndexInfos calls for segments to reduce RPC calls.

issue: #37634

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 14, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.67%. Comparing base (4820dd7) to head (b3cbe49).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/coordinator_broker.go 91.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37695      +/-   ##
==========================================
- Coverage   80.67%   80.67%   -0.01%     
==========================================
  Files        1357     1357              
  Lines      190739   190736       -3     
==========================================
- Hits       153883   153874       -9     
- Misses      31428    31429       +1     
- Partials     5428     5433       +5     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.91% <ø> (ø)
Go 83.18% <95.91%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 95.87% <100.00%> (-0.03%) ⬇️
internal/datacoord/index_service.go 92.94% <100.00%> (+<0.01%) ⬆️
internal/datacoord/task_scheduler.go 90.44% <100.00%> (ø)
internal/querycoordv2/checkers/index_checker.go 79.09% <100.00%> (+0.38%) ⬆️
internal/querycoordv2/task/executor.go 80.93% <100.00%> (+1.25%) ⬆️
pkg/util/merr/utils.go 84.00% <100.00%> (ø)
internal/querycoordv2/meta/coordinator_broker.go 91.40% <91.30%> (-0.06%) ⬇️

... and 39 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 15, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants