Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove unnecessary clone in SetState #37697

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #37637

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (5ae347a) to head (38fd5cd).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37697       +/-   ##
===========================================
+ Coverage   68.64%   80.66%   +12.01%     
===========================================
  Files         290     1357     +1067     
  Lines       25457   190667   +165210     
===========================================
+ Hits        17476   153805   +136329     
- Misses       7981    31430    +23449     
- Partials        0     5432     +5432     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.91% <100.00%> (+0.26%) ⬆️
Go 83.17% <94.73%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.51% <100.00%> (ø)
internal/datacoord/segment_info.go 84.72% <ø> (ø)

... and 1069 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 15, 2024
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Nov 15, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 15, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 18a6478 into milvus-io:master Nov 15, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm PR | need cherry-pick need cherry pick to other branches size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants