-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor web ui #37698
feat: refactor web ui #37698
Conversation
Welcome @mimoning! It looks like this is your first PR to milvus-io/milvus 🎉 |
@mimoning Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
@mimoning Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@mimoning E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37698 +/- ##
==========================================
- Coverage 80.67% 80.66% -0.02%
==========================================
Files 1357 1357
Lines 190680 190702 +22
==========================================
- Hits 153834 153826 -8
- Misses 31414 31436 +22
- Partials 5432 5440 +8
|
0a402fc
to
afe9abb
Compare
@mimoning E2e jenkins job failed, comment |
afe9abb
to
952b9c2
Compare
@mimoning E2e jenkins job failed, comment |
issue: milvus-io#36621 Signed-off-by: mimo.oyn <[email protected]>
952b9c2
to
61050df
Compare
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mimoning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -103,5 +103,6 @@ cwrapper_rocksdb_build/ | |||
internal/proto/**/*.pb.go | |||
internal/core/src/pb/*.pb.h | |||
internal/core/src/pb/*.pb.cc | |||
internal/http/internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary code
/lgtm |
issue: #36621