Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor web ui #37698

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

mimoning
Copy link
Contributor

@mimoning mimoning commented Nov 14, 2024

issue: #36621

  • The front-end code of the management interface has been refactored using React.
  • The interaction and display of the front-end interface have been optimized.

@sre-ci-robot
Copy link
Contributor

Welcome @mimoning! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@mimoning Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/feature Issues related to feature request from users labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@mimoning Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 14, 2024

@mimoning E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (65d3c66) to head (61050df).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37698      +/-   ##
==========================================
- Coverage   80.67%   80.66%   -0.02%     
==========================================
  Files        1357     1357              
  Lines      190680   190702      +22     
==========================================
- Hits       153834   153826       -8     
- Misses      31414    31436      +22     
- Partials     5432     5440       +8     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.92% <ø> (ø)
Go 83.17% <ø> (-0.02%) ⬇️

see 24 files with indirect coverage changes

@mimoning mimoning force-pushed the refactor/webui branch 7 times, most recently from 0a402fc to afe9abb Compare November 15, 2024 03:20
Copy link
Contributor

mergify bot commented Nov 15, 2024

@mimoning E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 15, 2024

@mimoning E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 added this to the 2.5.0 milestone Nov 15, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 15, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mimoning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -103,5 +103,6 @@ cwrapper_rocksdb_build/
internal/proto/**/*.pb.go
internal/core/src/pb/*.pb.h
internal/core/src/pb/*.pb.cc
internal/http/internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary code

@mergify mergify bot added the ci-passed label Nov 15, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 0f0162f into milvus-io:master Nov 15, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants