Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Store default value if ErrKeyNotFound is returned (#37691) #37705

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #37691
Related to #37690

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 15, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 15, 2024
Copy link
Contributor

mergify bot commented Nov 15, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.61%. Comparing base (c50cb8d) to head (cadaaf0).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
pkg/config/manager.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37705      +/-   ##
==========================================
+ Coverage   72.25%   80.61%   +8.35%     
==========================================
  Files        1069     1069              
  Lines      166881   166885       +4     
==========================================
+ Hits       120588   134541   +13953     
+ Misses      41878    27931   -13947     
+ Partials     4415     4413       -2     
Files with missing lines Coverage Δ
pkg/config/manager.go 84.61% <80.00%> (+0.20%) ⬆️

... and 230 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit e222289 into milvus-io:2.4 Nov 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants