Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use internal json(sonic) to replace std json lib #37708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Related to #35020

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 15, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 15, 2024

@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/enhancement Issues or changes related to enhancement dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 15, 2024
Copy link
Contributor

mergify bot commented Nov 15, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 15, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.67%. Comparing base (5ae347a) to head (bf519e3).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37708       +/-   ##
===========================================
+ Coverage   68.64%   80.67%   +12.02%     
===========================================
  Files         290     1357     +1067     
  Lines       25457   190680   +165223     
===========================================
+ Hits        17476   153831   +136355     
- Misses       7981    31420    +23439     
- Partials        0     5429     +5429     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.92% <100.00%> (+0.27%) ⬆️
Go 83.19% <94.44%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/compaction_task_meta.go 75.63% <ø> (ø)
internal/datacoord/import_meta.go 94.38% <ø> (ø)
internal/datacoord/import_task.go 98.26% <ø> (ø)
internal/datacoord/index_meta.go 95.89% <ø> (ø)
internal/datacoord/metrics_info.go 86.44% <ø> (ø)
...nternal/distributed/proxy/httpserver/handler_v2.go 91.69% <ø> (ø)
...ernal/distributed/proxy/httpserver/wrap_request.go 95.63% <ø> (ø)
...nternal/flushcommon/pipeline/flow_graph_manager.go 91.20% <ø> (ø)
internal/flushcommon/syncmgr/sync_manager.go 89.23% <ø> (ø)
internal/flushcommon/syncmgr/task.go 82.37% <ø> (ø)
... and 44 more

... and 1018 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 15, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants