Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Get shard client failed by client is closed #37729

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Get shard client failed by client is closed #37729

wants to merge 3 commits into from
+183 −178

Conversation

weiliu1031
Copy link
Contributor

issue: #37718
This PR refine the shard client ref counter, dec ref counter won't release client anymore, and only permit shard client manager to remove client.

@weiliu1031
fix: Get shard client failed by client is closed
7573463 
This PR refine the shard client ref counter, dec ref counter won't
release client anymore, and only permit shard client manager to remove client.

Signed-off-by: Wei Liu <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 15, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (1304b40) to head (6b0f912).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/shard_client.go 88.67% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37729      +/-   ##
==========================================
+ Coverage   80.57%   80.68%   +0.11%     
==========================================
  Files        1357     1357              
  Lines      190448   190705     +257     
==========================================
+ Hits       153449   153878     +429     
+ Misses      31588    31402     -186     
- Partials     5411     5425      +14
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.91% <ø> (+0.84%) ⬆️
Go 83.20% <88.67%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/lb_policy.go 98.03% <ø> (-0.03%) ⬇️
internal/proxy/look_aside_balancer.go 96.60% <ø> (-0.04%) ⬇️
internal/proxy/task_policies.go 86.20% <ø> (-0.46%) ⬇️
internal/proxy/shard_client.go 72.50% <88.67%> (+2.30%) ⬆️

... and 85 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 15, 2024
xiaofan-luan
xiaofan-luan reviewed Nov 16, 2024
View reviewed changes
internal/proxy/shard_client.go Outdated
defer ticker.Stop()

// record node's age, if node reach 3 consecutive failures, try to purge it
nodeAges := make(map[int64]int, 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is leaked.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to count time?

we can record last active time as a mark

@weiliu1031
fix review comment
fd0b8c2 
Signed-off-by: Wei Liu <[email protected]>
@mergify mergify bot removed the ci-passed label Nov 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2024

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
fix ut data race
6b0f912 
Signed-off-by: Wei Liu <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @sre-ci-robot @xiaofan-luan