Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Remove segment-level tag from monitoring metrics #37737

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

bigsheeper
Copy link
Contributor

When there are a large number of segments, the metrics consume a lot of memory. This PR Remove segment-level tag from monitoring metrics.

issue: #37636

pr: #37696

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (cdf703a) to head (a6d4fc1).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37737      +/-   ##
==========================================
- Coverage   80.65%   80.58%   -0.07%     
==========================================
  Files        1069     1069              
  Lines      166900   166878      -22     
==========================================
- Hits       134605   134485     -120     
- Misses      27902    27970      +68     
- Partials     4393     4423      +30     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 95.59% <100.00%> (-0.42%) ⬇️
internal/datacoord/meta.go 89.43% <100.00%> (-0.03%) ⬇️
internal/metastore/kv/datacoord/kv_catalog.go 74.51% <100.00%> (-0.08%) ⬇️
pkg/metrics/datacoord_metrics.go 51.92% <ø> (-11.85%) ⬇️
pkg/metrics/metrics.go 100.00% <ø> (ø)

... and 33 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 13f83df into milvus-io:2.4 Nov 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants