Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Accelerate the loading of collection #37741

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Remove unnecessary ListIndex, DescribeCollection and LoadPartitions RPC calls during collection loading.
  2. Remove unnecessary ListIndex and DescribeCollection RPC call during partition loading.

issue: #37166

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/internal-api labels Nov 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 16, 2024
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 16, 2024
Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (3cdb485) to head (8f7b43e).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37741   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files         290      290           
  Lines       25471    25471           
=======================================
  Hits        17553    17553           
  Misses       7918     7918           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.91% <ø> (ø)
Go ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants