don't confuse with different numbering bases #3660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated to this change, but I do wonder if the hashing in the document is correct e.g. |
Thanks for spotting that mistake. Fixed now. |
yeastplume
approved these changes
Jan 7, 2022
| peaks is 19-15=4. | ||
| After 2 more right shifts to peak size 3, we find 4 >= 3 and identify the 2nd peak, | ||
| reducing relative position to 4-3 = 1. | ||
| A final right shift gives a peak size of 1, and with 1 >= 1, we identified the 3rd and final peak. |
There was a problem hiding this comment.
This is definitely more correct in terms of keeping consistent with a 0 based index and the code, but I have to say I did like having the diagram in place and the 'all ones on the left' to assist with the process conceptually (even thought it was 1-index based).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change in MMR doc, rewriting a few paragraphs that for no good reason used 1-based positions.