Finally remove per-entity columns from EEA #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
rm-eea-entities-columns
branch
2 times, most recently
from
2fe0b41
to
207de6e
Compare
blkt
reviewed
Aug 28, 2024
database/migrations/000102_eea_rm_per_entities_columns.down.sql
Outdated
Show resolved
Hide resolved
blkt
reviewed
Aug 28, 2024
Comment on lines
321
to
337
| func (e *EEA) buildPullRequestInfoWrapper( | ||
| ctx context.Context, | ||
| repoID uuid.NullUUID, | ||
| prID uuid.UUID, | ||
| projID uuid.UUID, | ||
| prID uuid.NullUUID, | ||
| ) (*entities.EntityInfoWrapper, error) { | ||
| providerID, pr, err := getPullRequest(ctx, e.querier, projID, repoID.UUID, prID.UUID) | ||
| providerID, repoID, pr, err := getPullRequest(ctx, e.querier, projID, prID) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error getting pull request: %w", err) | ||
| } | ||
|
|
||
| return entities.NewEntityInfoWrapper(). | ||
| WithRepositoryID(repoID.UUID). | ||
| WithRepositoryID(repoID). | ||
| WithProjectID(projID). | ||
| WithPullRequest(pr). | ||
| WithPullRequestID(prID.UUID). | ||
| WithPullRequestID(prID). | ||
| WithProviderID(providerID), nil | ||
| } |
There was a problem hiding this comment.
nit: it feels that code might get shorter both here and inside getPullRequest (and the others) if you pass eiw down to it instead of returning data to add.
JAORMX
force-pushed
the
rm-eea-entities-columns
branch
3 times, most recently
from
3a6800a
to
11e0ba1
Compare
dmjb
previously approved these changes
Aug 29, 2024
JAORMX
force-pushed
the
rm-eea-entities-columns
branch
from
992e089
to
57c0d06
Compare
rdimitrov
approved these changes
Aug 29, 2024
jhrozek
approved these changes
Aug 29, 2024
Now that the queries aren't using it and the main logic actually uses the central entity instances table, we can drop these. Closes: #4169 Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
rm-eea-entities-columns
branch
from
57c0d06
to
db18589
Compare
jhrozek
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that the queries aren't using it and the main logic actually uses
the central entity instances table, we can drop these.
Closes: #4169
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: