Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable NATS test with higher timeout #4366

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

evankanderson
Copy link
Member

Summary

Re-enable tests for the NATS messaging channel; running this with go test -count 200 ./internal/events/nats produced 5 failures with the previous 5s timeout. Increasing the timeout to 15s avoided all timeouts.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

go test -count 200 ./internal/events/nats

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Sep 4, 2024

Coverage Status

coverage: 53.259% (+0.6%) from 52.658%
when pulling 98233ea on evankanderson:fix-nats-tests
into 87aae86 on stacklok:main.

@evankanderson evankanderson merged commit 8a60ee2 into mindersec:main Sep 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants