Do not reply that a package has an unfixed vulnerability when in fact it is malicious #4530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Malicious packages that have a vulnerability entry
MAL-
are in factmalicious. Our OSV evaluator handled the
MAL-
vulnerabilities the sameas all the others which meant that it would just reply with "A
vulnerability was found, but no fixed version exists yet".
A malicious package is unlikely to not be malicious again, so let's put
a sterner warning including a link to the vulnerability into the reply.
Fixes: #4528
Change Type
Testing
manually, see e.g. jakubtestorg/bad-python#266
Review Checklist: