Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto validation for project ID #4862

Merged

Conversation

eleftherias
Copy link
Contributor

Summary

Add validation to the proto file for all project ID fields.

Ref https://github.com/stacklok/minder-stories/issues/94

Fixes #(related issue)

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner November 1, 2024 15:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11632027627

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.226%

Totals Coverage Status
Change from base Build 11631234497: 0.0%
Covered Lines: 15535
Relevant Lines: 28130

💛 - Coveralls

@eleftherias eleftherias merged commit 3477898 into mindersec:main Nov 1, 2024
26 checks passed
@eleftherias eleftherias deleted the proto-project-id-validation branch November 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants