Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto validation for invite codes #4893

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add proto validation for invite codes #4893

merged 1 commit into from
Nov 6, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR adds proto validation for invite codes which are 48 random bytes that are then URL safe base64 encoded which end up being 64 bytes.

Ref https://github.com/stacklok/minder-stories/issues/94

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Signed-off-by: Radoslav Dimitrov <[email protected]>
@rdimitrov rdimitrov requested a review from a team as a code owner November 6, 2024 16:40
@rdimitrov rdimitrov self-assigned this Nov 6, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11708002683

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 54.766%

Totals Coverage Status
Change from base Build 11707315932: 0.003%
Covered Lines: 15535
Relevant Lines: 28366

💛 - Coveralls

@rdimitrov rdimitrov merged commit 7270a42 into main Nov 6, 2024
26 checks passed
@rdimitrov rdimitrov deleted the validate-code branch November 6, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants