Fix/llamas expressions fixes #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We filter duplicates ourselves.
Make the preview text more representative of the actual completion and support array literals which were previously missing.
Also adapt to related MixinExtras changes.
LlamaLad7
force-pushed
the
fix/llamas-expressions-fixes
branch
from
f51d82f
to
5831faa
Compare
src/main/kotlin/platform/mixin/expression/MEExpressionCompletionUtil.kt
Outdated
Show resolved
Hide resolved
Earthcomputer
approved these changes
Jul 9, 2024
Earthcomputer
merged commit eeb4dd5
into
minecraft-dev:mixinextras-expression
1 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticks off all the cards I had
See individual commits