Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LayeredIcon for mixin classes #2340

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Use LayeredIcon for mixin classes #2340

merged 5 commits into from
Aug 1, 2024

Conversation

kikugie
Copy link
Contributor

@kikugie kikugie commented Jul 30, 2024

Motivation

Newly introduced mixin files icons look awkward - pixelation becomes noticable, they don't fit with the Intellij icon style and don't convey the information about the type of the class:
image

Solution

Intellij supports layered icons, similar to Kotlin classes, which are more visually pleasing:

New UI - dark

image

Old UI - dark

image

@kikugie kikugie changed the title Mixin icons Use LayeredIcon for mixin classes Jul 30, 2024
@kikugie
Copy link
Contributor Author

kikugie commented Aug 1, 2024

Excuse the impatience, does this look good? (The old icon is irritating a bit)

@Earthcomputer Earthcomputer merged commit 93be505 into minecraft-dev:dev Aug 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants