Add json5 support to mixin config jsons #2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedNesto
requested changes
Sep 19, 2024
|
I tested that initially and it causes a json language inspection in the mixin json for violating the json standard as the config file type specifies that the language is Json not Json5 
|
RedNesto
requested changes
Sep 23, 2024
src/main/kotlin/platform/mixin/config/reference/MixinConfigReferenceContributor.kt
Outdated
Show resolved
Hide resolved
RedNesto
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow mixin config json inspections and references to recognise mixin configs of the json5 file type
Motivation
Stonecutter, a gradle pre-processor plugin has been gaining traction for it's use in multi-loader, multi-version projects, and a plugin that was developed alongside it, j52j, which converts json5 files to json during compilation allowing versioned comments within json files resulting in json5 being used as the file type for a mixin config:
https://github.com/Bawnorton/BetterTrims/blob/8558c398e0cd5a85fdd5dce6b2ed9e410d239743/src/main/resources/bettertrims.mixins.json5#L6-L12
mcdev doesn't recognise json5 as a valid file type for mixin config jsons, so this pr adds that support.