Fix deadlock when closing window in callback #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherHX
requested changes
Dec 27, 2024
| @@ -911,6 +912,7 @@ void ImGuiUIDrawFrame(GameWindow* window) { | |||
| default: | |||
| break; | |||
| } | |||
| activeWindowsLock.try_lock(); | |||
There was a problem hiding this comment.
What if
- this returns false?
- between line 852 and 915 activeWindows and activeWindows[i]->controls has been altered?
I'm more towards agreeing to wrap the content of mcpelauncher_show_window / mcpelauncher_close_window in std::thread([]() -> { <old-body> }).detach(); e.g. queue the mutex lock into it's own thread so the caller don't need to care about the consequences
|
Closing in favor of #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.