Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement get-mods.sh as a Python script #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vilhelmgray
Copy link

Users no longer require sh, curl, unzip, or a *nix environment in order
to automatically download the required mods. This should allow users of
other operating systems such as Windows to also use this script.

Bug: #28

@vilhelmgray vilhelmgray force-pushed the sanssh branch 2 times, most recently from 37e17b5 to 0ddc5b3 Compare April 1, 2020 16:15
@sofar
Copy link
Member

sofar commented Apr 2, 2020

Is there a reason you changed the interface and made the argument a required thing?

This is a cli application (still) so no matter what, the user will need to execute it from a cmd.exe or a terminal.

@vilhelmgray
Copy link
Author

Is there a reason you changed the interface and made the argument a required thing?

Thinking over this a second time, I realized that users wouldn't need to download the mods anywhere else. So I've removed the argument and reverted back to the original interface of simply executing the script in the new world folder directory.

This is a cli application (still) so no matter what, the user will need to execute it from a cmd.exe or a terminal.

Yes, I agree. I plan on submitting an update some time next week that will add in an optional gui, but that will be purely an alternative interface for convenience as mcimport.sh is now.

This particular get_mods patch is a prerequisite for the future optional gui patch I am writing, but is otherwise unrelated.

Users no longer require sh, curl, unzip, or a *nix environment in order
to automatically download the required mods. This should allow users of
other operating systems such as Windows to also use this script.

Bug: minetest-tools#28
@sofar
Copy link
Member

sofar commented Apr 3, 2020

I would hold off on an actual GUI. If we go that route, I would rather make e.g. golang based binaries that can work entirely by themselves that have embedded gui libraries, so that it just works out of the box on any supported architecture, instead of having to install python, and then install python libraries, which is just way too complex for the type of user that I see asking for help with mcimport.

@vilhelmgray
Copy link
Author

That's a fair point. I'll stop further development on a gui interface for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants