-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nMFI normalisation type #174
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #174 +/- ##
==========================================
+ Coverage 86.60% 87.10% +0.50%
==========================================
Files 13 14 +1
Lines 1515 1574 +59
==========================================
+ Hits 1312 1371 +59
Misses 203 203 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I like that the get_nmfi
function is kinda separated. I would consider extending the vignettes and state there clearly what nMFI is and how can a user get that data.
Besides that i have two minor nitpicks into the code, not a big deal, but I would like to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see vignettes. I added some code concerns that I have not caught in the first round of review
Co-authored-by: Jakub Grzywaczewski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
get_nmfi
process_plate
function to handle new normalisation typeget_nMFI
functionprocess_plate
This PR should be merged after a successful review of #171