Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nMFI normalisation type #174

Merged
merged 28 commits into from
Oct 16, 2024
Merged

nMFI normalisation type #174

merged 28 commits into from
Oct 16, 2024

Conversation

Fersoil
Copy link
Collaborator

@Fersoil Fersoil commented Oct 11, 2024

  • Added function get_nmfi
  • modified process_plate function to handle new normalisation type
  • added tests and docs for the get_nMFI function
  • added tests for process_plate

This PR should be merged after a successful review of #171

@Fersoil Fersoil marked this pull request as ready for review October 11, 2024 13:05
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (dc478e9) to head (f24bd5a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
R/process-plate.R 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #174      +/-   ##
==========================================
+ Coverage   86.60%   87.10%   +0.50%     
==========================================
  Files          13       14       +1     
  Lines        1515     1574      +59     
==========================================
+ Hits         1312     1371      +59     
  Misses        203      203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fersoil Fersoil linked an issue Oct 13, 2024 that may be closed by this pull request
@Fersoil Fersoil mentioned this pull request Oct 13, 2024
Copy link
Collaborator

@ZetrextJG ZetrextJG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I like that the get_nmfi function is kinda separated. I would consider extending the vignettes and state there clearly what nMFI is and how can a user get that data.

Besides that i have two minor nitpicks into the code, not a big deal, but I would like to

R/process-plate.R Outdated Show resolved Hide resolved
tests/testthat/test-get-nmfi.R Outdated Show resolved Hide resolved
@ZetrextJG ZetrextJG self-requested a review October 14, 2024 20:11
Copy link
Collaborator

@ZetrextJG ZetrextJG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see vignettes. I added some code concerns that I have not caught in the first round of review

vignettes/example_script.Rmd Outdated Show resolved Hide resolved
R/get-nmfi.R Outdated Show resolved Hide resolved
R/get-nmfi.R Outdated Show resolved Hide resolved
R/get-nmfi.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZetrextJG ZetrextJG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZetrextJG ZetrextJG merged commit d27fcd4 into dev Oct 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add nMFI to final output
2 participants