High dose hook #182
High dose hook #182
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #182 +/- ##
==========================================
+ Coverage 87.16% 87.38% +0.22%
==========================================
Files 14 14
Lines 1581 1609 +28
==========================================
+ Hits 1378 1406 +28
Misses 203 203 ☔ View full report in Codecov by Sentry. |
| #' | ||
| is.decreasing <- function(x) { | ||
| stopifnot(is.numeric(x) || is.null(x)) | ||
| if (any(is.na(x))) { |
There was a problem hiding this comment.
if this function is gonna be used only in handle_high_dose_hook then as a user I would prefer to see different error message. I know that this check fits here but I would move it to handle_high_dose_hook and there gave it different, more specific error message such as "NA values detected in the dilutions while handling high dose hook" or something similar
There was a problem hiding this comment.
I guess such a situation should not happen. In general, I think, it would mean that a standard curve sample has a missing dilution value
There was a problem hiding this comment.
But I'd love to see a test in which we process a plate with high-hook
Implement high dose hook phenomenon handling as described in #179