Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Need-Discussion] Separate tier add command to sub commands per tier backend #4801

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vadmeste
Copy link
Member

'mc ilm tier edit' is a bit weird; it seems we need to do a revision for edit command in mc and MinIO server API as well

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0).
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Currently the flags help is crowded. This commit will split the add
command to more sub-commands, minio, s3, gcs, azure; so it is easy
for users to see associated flags for each backend tier

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Currently the flags help is crowded. This commit will split the add
command to more sub-commands, minio, s3, gcs, azure; so it is easy for
users to see associated flags for each backend tier
@vadmeste vadmeste changed the title Separate tier add command to sub commands per tier backend [Need-Discussion] Separate tier add command to sub commands per tier backend Dec 22, 2023
@klauspost
Copy link
Contributor

Solid improvement 👍🏼 from me.

@harshavardhana
Copy link
Member

@vadmeste what discussion is pending?

@klauspost
Copy link
Contributor

--- FAIL: TestAutoCompletionCompletness (0.00s)
    auto-complete_test.go:56: Missing completion function: Completion for `/ilm/tier/add/azure` not found

@vadmeste
Copy link
Member Author

@harshavardhana we need to fix 'mc ilm tier edit' command. Currently there is no easy change without breaking the API, if you take a look at that command help, you will understand we cannot have subcommands in it. It looks like this requires a breaking API in the server side as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants