Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework entire code for correctness and potential bug fixes #111

Merged
merged 83 commits into from
Mar 16, 2024
Merged

Rework entire code for correctness and potential bug fixes #111

merged 83 commits into from
Mar 16, 2024

Commits on Mar 13, 2024

  1. Switched the cast to bool operators to explicit mode. The implicit on… 

    …es are the root of all evil.
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    74d2b90 View commit details
    Browse the repository at this point in the history

  2. Implicit bool cast bug: added relational operators to Time

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3bcde85 View commit details
    Browse the repository at this point in the history

  3. Implicit bool cast bug: error string building

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bcbe506 View commit details
    Browse the repository at this point in the history

  4. Added explicit casts. Some code needs further inspection, as it makes… 

    … no sense
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7128abd View commit details
    Browse the repository at this point in the history

  5. Implicit bool cast bug: added error streaming operator

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3138280 View commit details
    Browse the repository at this point in the history

  6. Improved const-correctness, defaulted the constructor and destructor

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    dd299ee View commit details
    Browse the repository at this point in the history

  7. Const correctness and copy elimination

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0be9be6 View commit details
    Browse the repository at this point in the history

  8. Improved const-correctness, defaulted the constructor and destructor,… 

    … resolved the streaming bugs caused by the implicit bool conversion
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3d9e915 View commit details
    Browse the repository at this point in the history

  9. Improved const-correctness, defaulted the constructor and destructor

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f2a16f6 View commit details
    Browse the repository at this point in the history

  10. Improved const-correctness, defaulted the constructors and destructor… 

    …s, explicit virtual ovverrides
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2509218 View commit details
    Browse the repository at this point in the history

  11. De-inlining of complex functions

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a70501e View commit details
    Browse the repository at this point in the history

  12. Const correctness + copy elision

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    79df2b9 View commit details
    Browse the repository at this point in the history

  13. Improved const-correctness, defaulted the constructors and destructors

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    66b1854 View commit details
    Browse the repository at this point in the history

  14. COnst-correctness and copy elision

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bc27b78 View commit details
    Browse the repository at this point in the history

  15. Const-correctness, copy elision, defaulting constructors and destructors

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3ca5099 View commit details
    Browse the repository at this point in the history

  16. Const-correctness, copy elision, defaulting constructors and destructors

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d4b1788 View commit details
    Browse the repository at this point in the history

  17. De-inlined complex functions

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    de743cf View commit details
    Browse the repository at this point in the history

  18. De-inlined complex functions

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    af4d582 View commit details
    Browse the repository at this point in the history

  19. De-inlined complex functions, cleaned up includes

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c57b7d2 View commit details
    Browse the repository at this point in the history

  20. De-inlined complex functions, added <<() to Time

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5eb57f0 View commit details
    Browse the repository at this point in the history

  21. De-inlined complex functions

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    cae79d1 View commit details
    Browse the repository at this point in the history

  22. Bugfix: provided a default value

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    48d4f08 View commit details
    Browse the repository at this point in the history

  23. De-inlined complex functions, defaulted constructors and destructors,… 

    … const correctness
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    408cc5e View commit details
    Browse the repository at this point in the history

  24. De-inlined complex functions, defaulted constructors and destructors,… 

    … const correctness
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    474dbd4 View commit details
    Browse the repository at this point in the history

  25. ebasing nullptr

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    efa2c24 View commit details
    Browse the repository at this point in the history

  26. Inlined the << operator

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    33de57f View commit details
    Browse the repository at this point in the history

  27. Conditionally enabled the spaceship operator

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    792ba02 View commit details
    Browse the repository at this point in the history

  28. Implemented the basic version of Time::Compare

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    7f4f724 View commit details
    Browse the repository at this point in the history

  29. Enabled -Wall; follow-up fixes batch #1

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0515f1c View commit details
    Browse the repository at this point in the history

  30. Enabled -Wall; follow-up fixes batch #2

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ada8c43 View commit details
    Browse the repository at this point in the history

  31. Const correctness, copy elision

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    20fe111 View commit details
    Browse the repository at this point in the history

  32. Const reinforcement

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ae8367d View commit details
    Browse the repository at this point in the history

  33. Defaulted constructors and destructors, const correctness

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    40cb39a View commit details
    Browse the repository at this point in the history

  34. Added explicit move construction support

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1aaeff8 View commit details
    Browse the repository at this point in the history

  35. Const hardening, copy elision

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    61ca42c View commit details
    Browse the repository at this point in the history

  36. Copy elision

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ab7269b View commit details
    Browse the repository at this point in the history

  37. De-inlined complex functions, defaulted constructors and destructors,… 

    … const correctness
    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    65cf438 View commit details
    Browse the repository at this point in the history

  38. Initialization improvements, defaulted destructors

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    289f7ea View commit details
    Browse the repository at this point in the history

  39. Initialization improvements

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    90adac3 View commit details
    Browse the repository at this point in the history

  40. Restored Windows compatibility

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6561239 View commit details
    Browse the repository at this point in the history

  41. rvalue references are not needed for arithmetic types

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    935037d View commit details
    Browse the repository at this point in the history

  42. The default copy constructor is fine

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d980246 View commit details
    Browse the repository at this point in the history

  43. Added -Wall -Wextra

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2c83f9a View commit details
    Browse the repository at this point in the history

  44. Added default initializaters, as they are skipped at the call sites

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    11efff0 View commit details
    Browse the repository at this point in the history

  45. Unused parameter

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d390957 View commit details
    Browse the repository at this point in the history

  46. Added default initializaters, as they are skipped at the call sites

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    8703679 View commit details
    Browse the repository at this point in the history

  47. De-inlined virtual functions, defaulted constructors and destructors

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    47f96c7 View commit details
    Browse the repository at this point in the history

  48. Added default initializaters, as they are skipped at the call sites

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    137bef3 View commit details
    Browse the repository at this point in the history

  49. ebasingization improvements, defaulted destructors

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d7d8b7e View commit details
    Browse the repository at this point in the history

  50. -Wextra fixes

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    27b4215 View commit details
    Browse the repository at this point in the history

  51. -Wconversion fixes

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    24e4a55 View commit details
    Browse the repository at this point in the history

  52. Bugfix: broken copy construction

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1e041c7 View commit details
    Browse the repository at this point in the history

  53. Switched to default copy constructor and assignment operator

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    568c1e4 View commit details
    Browse the repository at this point in the history

  54. Assignment optimization

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9c42c5e View commit details
    Browse the repository at this point in the history

  55. Bugfix: ToLower

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e05c022 View commit details
    Browse the repository at this point in the history

  56. Removed a couple of PWTODOs

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e60bce1 View commit details
    Browse the repository at this point in the history

  57. ebasingfixes

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4ca7777 View commit details
    Browse the repository at this point in the history

  58. Replaced h with result_headers, fixed the ifs lacking braces

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    1847979 View commit details
    Browse the repository at this point in the history

  59. Linter

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    78dec1f View commit details
    Browse the repository at this point in the history

  60. Namet member initialization is a C++20 feature

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4f8d571 View commit details
    Browse the repository at this point in the history

  61. Removed a class of resolved comments

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    369ab9c View commit details
    Browse the repository at this point in the history

  62. Removed a class of resolved comments #2

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    fbbe516 View commit details
    Browse the repository at this point in the history

  63. Bugfix: resp is always false in the else branch

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e010dd6 View commit details
    Browse the repository at this point in the history

  64. Windows warning fixes, part #1

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    0426d95 View commit details
    Browse the repository at this point in the history

  65. Fixed MSVC warnings

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2b07aa1 View commit details
    Browse the repository at this point in the history

  66. Fixed MSVC warnings

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    297cac8 View commit details
    Browse the repository at this point in the history

  67. Fixed MSVC warnings

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9e21211 View commit details
    Browse the repository at this point in the history

  68. Fixed MSVC warnings

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9bcc55f View commit details
    Browse the repository at this point in the history

  69. Muted the Windows headers-related warnings

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    00ccc61 View commit details
    Browse the repository at this point in the history

  70. Bugfix: narrowing conversion

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    68fbea4 View commit details
    Browse the repository at this point in the history

  71. throw() is deprecated

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f7cb294 View commit details
    Browse the repository at this point in the history

  72. function-try-block make sure no exception passes unnoticed

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e4643bb View commit details
    Browse the repository at this point in the history

  73. Use throw; for rethrowing exceptions

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4eb531d View commit details
    Browse the repository at this point in the history

  74. Linter

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    eaf0100 View commit details
    Browse the repository at this point in the history

  75. Linter

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    72408e0 View commit details
    Browse the repository at this point in the history

  76. Linter

    @piotr-topnotch
    piotr-topnotch committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f884e97 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Resolved the Time::operator << issue

    @piotr-topnotch
    piotr-topnotch committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f1201e7 View commit details
    Browse the repository at this point in the history

  2. Resolved the UTC flag issue: Bala wants to remove it

    @piotr-topnotch
    piotr-topnotch committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3545753 View commit details
    Browse the repository at this point in the history

  3. Removed the PWTODO comments

    @piotr-topnotch
    piotr-topnotch committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8707407 View commit details
    Browse the repository at this point in the history

  4. Linter

    @piotr-topnotch
    piotr-topnotch committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    7833183 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Replaced main() with args with just main(), as it is a legal C++ sign… 

    …ature
    @piotr-topnotch
    piotr-topnotch committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8cf60ad View commit details
    Browse the repository at this point in the history

  2. Aligned the return types

    @piotr-topnotch
    piotr-topnotch committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a24226c View commit details
    Browse the repository at this point in the history

  3. Linter

    @piotr-topnotch
    piotr-topnotch committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b884f0c View commit details
    Browse the repository at this point in the history