Allow domains with . at the end (#1110)

Fixes #1109
minio · May 23, 2019 · c6c2912 · c6c2912
1 parent 1add5d5
commit c6c2912
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/s3utils/utils.go b/pkg/s3utils/utils.go
@@ -47,8 +47,8 @@ func IsValidDomain(host string) bool {
 	if host[len(host)-1:] == "_" || host[:1] == "_" {
 		return false
 	}
-	// host cannot start or end with a "."
-	if host[len(host)-1:] == "." || host[:1] == "." {
+	// host cannot start with a "."
+	if host[:1] == "." {
 		return false
 	}
 	// All non alphanumeric characters are invalid.

diff --git a/pkg/s3utils/utils_test.go b/pkg/s3utils/utils_test.go
@@ -99,6 +99,7 @@ func TestIsValidDomain(t *testing.T) {
 		{"s3.amz.test.com", true},
 		{"s3.%%", false},
 		{"localhost", true},
+		{"localhost.", true}, // http://www.dns-sd.org/trailingdotsindomainnames.html
 		{"-localhost", false},
 		{"", false},
 		{"\n \t", false},