Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): prevent double initialization on datepicker components #752

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

chrispymm
Copy link
Contributor

fix #751

Prevent double-initialization of the component by adding a data-initialized attribute onto the $module after the init() method has run. The init() method then checks for the presence of the attribute and aborts if it is present.

@chrispymm chrispymm requested a review from a team as a code owner September 19, 2024 09:00
@helennickols helennickols merged commit 7f84baf into main Sep 19, 2024
18 checks passed
@helennickols helennickols deleted the datepicker-fix branch September 19, 2024 09:53
gregtyler pushed a commit that referenced this pull request Sep 19, 2024
## [2.2.2](v2.2.1...v2.2.2) (2024-09-19)

### Bug Fixes

* **datepicker:** prevent double initialization on datepicker components ([#752](#752)) ([7f84baf](7f84baf)), closes [#751](#751)
@gregtyler
Copy link
Contributor

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple MoJ Date Pickers - Incorrect Behaviour
3 participants