-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHP RFC: Deprecate implicitly nullable parameter types #869
Conversation
@andypost , please explain how Mink method signatures are affecting/blocking Drupal? |
Deprecation warnings affects tests so they fail. For example this pipeline
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Doesn't look like a BC break.
I did update of comment with example |
I checked files with |
Last deprecations for PHP 8.4 will be commited in 2 weeks https://wiki.php.net/todo/php84 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
=========================================
Coverage 98.72% 98.72%
- Complexity 374 389 +15
=========================================
Files 24 24
Lines 1022 1022
=========================================
Hits 1009 1009
Misses 13 13 ☔ View full report in Codecov by Sentry. |
Any chance to get this one commited? RC1 does not bring new deprecations |
Merged, thank you @andypost . |
It will be a blocker for Drupal 11
Links