Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posibility to use Bearer Token for auth #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zunkree
Copy link

@zunkree zunkree commented Dec 19, 2018

No description provided.

@@ -12,8 +12,7 @@ h3 { font-size: 16px; }
pre {
background-color: #eff0f1;
padding: 5px;
white-space: pre-wrap;
overflow-wrap: break-word;
overflow: auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we revert the CSS change - overflow:auto causes a horizontal scrollbar which we would rather avoid.

@@ -64,13 +64,14 @@ type Cluster struct {
K8s_Master_URI string
K8s_Ca_URI string
K8s_Ca_Pem string
Bearer_Token bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename this to Use_Bearer_Token to make it a bit clearer?

@nickmintel
Copy link
Contributor

@zunkree thanks for this - could you give some info on the use-case for this (I might add to the documentation when this would be useful).

I'm guessing the api-server is not configured for oidc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants