fix: month abbreviation locale in domestic proof (#14)

minvws · Jul 2, 2021 · 70b4327 · 70b4327
1 parent 3ccf2a0
commit 70b4327
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/src/proofs.js b/src/proofs.js
@@ -11,14 +11,15 @@ import {
  * TODO any type
  * @param {import("./types").ProofData} proofData
  * @param {any} holderConfig
+ * @param {import("./types").Locale} [locale]
  * @return {import("./types").Proof[]}
  */
-export const parseProofData = (proofData, holderConfig) => {
+export const parseProofData = (proofData, holderConfig, locale) => {
     /** @type {import("./types").Proof[]} */
     const proofs = [];
 
     if (proofData.domestic) {
-        proofs.push(domesticProof(proofData.domestic));
+        proofs.push(domesticProof(proofData.domestic, locale));
     }
     if (proofData.european) {
         for (const proof of europeanProofs(proofData.european, holderConfig)) {
@@ -31,9 +32,10 @@ export const parseProofData = (proofData, holderConfig) => {
 
 /**
  * @param {import("./types").DomesticProofData} data
+ * @param {import("./types").Locale} [locale]
  * @return {import("./types").Proof}
  */
-const domesticProof = (data) => {
+const domesticProof = (data, locale) => {
     const validFromDate = parseInt(data.attributes.validFrom, 10) * 1000;
     return {
         proofType: "domestic",
@@ -53,7 +55,7 @@ const domesticProof = (data) => {
         birthDateStringShort: formatBirthDate(
             data.attributes.birthDay,
             data.attributes.birthMonth,
-            "nl"
+            locale || "nl"
         ),
 
         validFromDate,

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,8 +1,8 @@
 {
   "include": ["src/**/*"],
   "compilerOptions": {
-    "allowJs": false,
-    "checkJs": false,
+    "allowJs": true,
+    "checkJs": true,
     "declaration": true,
     "emitDeclarationOnly": true,
     "moduleResolution": "node",

diff --git a/types/date.d.ts b/types/date.d.ts
@@ -1,5 +1,5 @@
-export function monthNameShort(locale: import("./types").Locale, month: string | number): string;
-export function formatBirthDate(birthDay: string, birthMonth: string): string;
+export function monthNameShort(month: string | number, locale: import("./types").Locale): string;
+export function formatBirthDate(birthDay: string, birthMonth: string, locale: import("./types").Locale): string;
 export function formatDate(dateTimeMs: number | Date): string;
 export function formatDateTime(dateTimeMs: number | Date): string;
 export function hoursInMs(hours: string): number;
diff --git a/types/proofs.d.ts b/types/proofs.d.ts
@@ -1 +1 @@
-export function parseProofData(proofData: import("./types").ProofData, holderConfig: any): import("./types").Proof[];
+export function parseProofData(proofData: import("./types").ProofData, holderConfig: any, locale?: import("./types").Locale): import("./types").Proof[];