-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique constraint to database plugin names #3556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny remark and good point from @underdarknl. Looks good otherwise 👍
QA notes:
|
@stephanie0x00 Thanks! And: handling of this error in Rocky will be handled in several places in #3566 |
…mes' into feature/enforce-unique-plugin-names
Changes
Add unique constraint to database plugin names and align API behavior
Issue link
Closes #3547
Demo
QA notes
Please check you cannot create two plugins with the same name from Rocky!
Code Checklist
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.