Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle existing Boefje name #3573

Merged
merged 181 commits into from
Oct 2, 2024
Merged

Handle existing Boefje name #3573

merged 181 commits into from
Oct 2, 2024

Conversation

madelondohmen
Copy link
Contributor

@madelondohmen madelondohmen commented Sep 23, 2024 •
edited
Loading

Changes

This PR handles the exception (in the form) that occurs when a user tries to create/edit a Boefje with a name that already exists.

Followup of #3521

  • Adds an error message to the name field (lay-out of error message will be fixed in Fixes notification alignment #3522)
  • Optimizes the code
  • AddBoefjeVariantView now redirects to the new plugin_id (instead of the "original" boefje id.

Issue link

Closes #3566
Closes #3586

Demo

afbeelding

QA notes

Please add some information for QA on how to test the newly created code.

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made. // No new tests needed
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen
Init boefje setup page
7f5b70c
@madelondohmen
Update form
af53653
@madelondohmen
Update form page
8d8fe18
@madelondohmen
Update boefje detail page
4dee801
@madelondohmen
Update settings section
32748b1
@madelondohmen
Add container image section
cc3229c
@madelondohmen
Changes on boefje detail page
35a7374
@madelondohmen
Merge remote-tracking branch 'origin/main' into feature/add-new-boefje
9e317eb
@madelondohmen
Merge branch 'main' into feature/add-new-boefje
c815078
@madelondohmen
Update boefje setup form
b7c2023
@madelondohmen
Handle form submit
23be912
@madelondohmen
Small fixes
e9ddf34
@madelondohmen
Add produces
e67af07
@madelondohmen
Fix empty section on boefje detail page
dd4cb49
@madelondohmen
Update translations
88791f3
@madelondohmen
Merge branch 'main' into feature/add-new-boefje
c429a72
@madelondohmen
Add boefje permission
c9ca645
@madelondohmen
Small changes
b9ffb9b
@madelondohmen
Update schema help text
3232249
@madelondohmen
Fix parse_boefje
ce4efa0
@madelondohmen
Handle wrong schema input
c55e1e1
@madelondohmen
Update tests
8bc48f3
@madelondohmen
Small fixes
00d0181
@madelondohmen
Fixing type and create_plugin
bde6c8e
@madelondohmen
Fix create_plugin
0a6d501
@madelondohmen
Fixes in form_valid
30e38f6
@madelondohmen
Fix produces section when data is empty
f8d7350
@madelondohmen
Merge branch 'main' into feature/add-new-boefje
2ebf22c
@madelondohmen
Create new variant boefjes
bad59c9
@madelondohmen
Add explanation
23e519c
Rieven
Rieven reviewed Sep 30, 2024
View reviewed changes
rocky/katalogus/client.py Outdated Show resolved Hide resolved
ammar92 and others added 21 commits October 1, 2024 08:30
@ammar92
Revert "Rework"
dab1c79 
This reverts commit e02d26c.
@ammar92
Rework
434ecf3
@ammar92
Language update
36a5d4b
@ammar92
Merge branch 'main' into feature/handle-existing-plugin-name
c031db5 
# Conflicts:
#	rocky/katalogus/views/boefje_setup.py
#	rocky/rocky/locale/django.pot
@ammar92
Language update
4d7f3b4
@ammar92
Fixed types
47d05f5
@ammar92
Fix
a98254d
@ammar92
Fix
acdb4e5
@ammar92
Fix
bafa6ca
@ammar92
Merge remote-tracking branch 'origin/feature/handle-existing-plugin-n…
3342546 
…ame' into feature/handle-existing-plugin-name
@madelondohmen
Fix exception for create_boefje
7758bb9
@madelondohmen
Remove id and name exceptions and create generic exception
49b7625
@madelondohmen
Update translations
5651125
@madelondohmen
Merge branch 'main' into feature/handle-existing-plugin-name
9cbdb10
@ammar92
Fix
aecd580
@madelondohmen
Merge branch 'main' into feature/handle-existing-plugin-name
ea83c9b
@ammar92
Fixed KATalogusHTTPStatusError and unit test
724e6e8
@Donnype
WIP: integrate worker with report scheduling
d58febd
@ammar92
Fixed unit test in boefje module
a621aca
@ammar92
Merge remote-tracking branch 'origin/feature/handle-existing-plugin-n…
5b473d7 
…ame' into feature/handle-existing-plugin-name

# Conflicts:
#	boefjes/tests/integration/test_api.py
@Donnype
"message" should be "detail"
d0d42c0
@underdarknl underdarknl merged commit bfafef8 into main Oct 2, 2024
14 of 15 checks passed
@underdarknl underdarknl deleted the feature/handle-existing-plugin-name branch October 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rieven Rieven Rieven left review comments

@underdarknl underdarknl underdarknl approved these changes

@ammar92 ammar92 ammar92 left review comments

Assignees

@madelondohmen madelondohmen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editting an "out of the box" plugin/boefje results in a 404 error Error handling for duplicate Boefje name
6 participants
@madelondohmen @underdarknl @ammar92 @Rieven @Donnype @noamblitz