Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: filter icon positioning #616

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix!: filter icon positioning #616

wants to merge 2 commits into from

Conversation

HeleenSG
Copy link
Contributor

@HeleenSG HeleenSG commented Aug 7, 2024 •
edited
Loading

Solves:

  • Icon positioning within filter button making it possible to position the icon to the left as well as to the right
  • Inconsistent variable name (::after --filter-button-icon-before...)

Todo:

  • Add span through JS

Breaking change:
Removes "--filter-button-icon-before-open-content" and "--filter-button-icon-before-close-content"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ppvg ppvg

@HeleenSG HeleenSG

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeleenSG @ppvg