Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure pak includes "LinkingTo" dependencies to avoid rsconnect errors #23

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

riccardoporreca
Copy link
Member

In particular, rsconnect deployments would need all transitive LinkingTo-only dependencies to be installed, but those are by default not installed by pak, see r-lib/pak#485.

A concrete instance of this was detected and fixed in miraisolutions/rTRhexNG#5

…rors

* In particular, rsconnect deployments would need all transitive LinkingTo-only dependencies to be installed, but those are by default not installed by pak, see r-lib/pak#485.
Copy link
Member

@GuidoMaggio GuidoMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@riccardoporreca riccardoporreca merged commit 842b40b into master Jan 31, 2024
4 checks passed
@riccardoporreca riccardoporreca deleted the feature/pak-include-linkingto-for-rsconnect branch January 31, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants